search

kubeflow-kale / jupyterlab-kubeflow-kale

JupyterLab extension to provide a Kubeflow specific left area for Notebooks deployment
Apache License 2.0
18 stars 12 forks source link

Produce docker image warning #42

Closed StefanoFioravanzo closed 4 years ago

StefanoFioravanzo commented 4 years ago

When clicking the compile/build/deploy button, check if the current notebook image is different from the NotebookServer's one. In that case, produce a warning dialog informing the user, asking whether to continue or not.

@tasos-ale Since NotebookUtils.showYesNoDialog is async, this makes the function async. Is it ok?

StefanoFioravanzo commented 4 years ago

@elikatsis I addressed your comments and changed a bit the formatting of the message. Also, I grouped together the body generation of NotebookUtils.showMessage and NotebookUtils.showYesNoDialog in NotebookUtils.buildDialogBody

StefanoFioravanzo commented 4 years ago

@elikatsis Now the docker image is updated on deploy just when the current state has an empty value, just like we discussed. Moreover, thanks to @tasos-ale 's advice, now the placeholder value work correctly.

For the placeholder value: note that I had to set the InputLabelProps to true when the placeholder is present. Might be worth remembering for the future. https://github.com/kubeflow-kale/jupyterlab-kubeflow-kale/pull/42/commits/9ed47684b247c92a599fef663219d744828a0f45#diff-12f5ae63fcc38a513b1de1cde98c411cR141