search

kubeflow / arena

A CLI for Kubeflow.
Apache License 2.0
733 stars 177 forks source link

⚠️ Breaking Changes: Migrate model subcommand to model analyze #1060

Closed ChenYi015 closed 6 months ago

ChenYi015 commented 6 months ago

What this PR does / why we need it:

Migrate arena model subcommand to arena model analyze.

Which issue(s) this PR fixes: Fixes #1061

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Syulin7 commented 6 months ago

@ChenYi015 Thanks! Looks good. Can you do a rebase?

ChenYi015 commented 6 months ago

@ChenYi015 Thanks! Looks good. Can you do a rebase?

Done!

Syulin7 commented 6 months ago

/lgtm /approve

google-oss-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, Syulin7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/arena/blob/master/OWNERS)~~ [Syulin7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment