search

kubeflow / arena

A CLI for Kubeflow.
Apache License 2.0
730 stars 177 forks source link

Support ray job #1123

Open qile123 opened 2 weeks ago

qile123 commented 2 weeks ago

What this PR does / why we need it: This PR is used to support ray job in arena.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Fixes #1120

qile123 commented 2 weeks ago

@cheyang @Syulin7

Syulin7 commented 2 weeks ago

@qile123 Thank you for this great contribution! Please rebase your PR.

ChenYi015 commented 4 days ago

@qile123 Are you willing to contribute some docs about how to submit an example Ray job?

qile123 commented 3 days ago

Are you willing to contribute some docs about how to submit an example Ray job?

Certainly, I'm more than happy to contribute documentation on submitting a sample Ray job.

ChenYi015 commented 1 day ago

@qile123 Could you rebase this PR please? There are some merge conflicts due to the recent merged PRs.

qile123 commented 1 day ago

@qile123 Could you rebase this PR please? There are some merge conflicts due to the recent merged PRs.

sure

google-oss-prow[bot] commented 7 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/arena/blob/master/OWNERS)~~ [ChenYi015] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ChenYi015 commented 7 hours ago

@qile123 Thanks for the great contribution of adding support for Ray job! LGTM, will wait for another approval @cheyang @Syulin7 .

qile123 commented 6 hours ago

@qile123 Thanks for the great contribution of adding support for Ray job! LGTM, will wait for another approval @cheyang @Syulin7 .

Thank you for your positive feedback and for reviewing the changes that add support for Ray jobs! I appreciate your time and input.