Fix etjob rendering error when using local logging dir

kubeflow / arena

A CLI for Kubeflow.

Apache License 2.0

739 stars 178 forks source link

Fix etjob rendering error when using local logging dir #1203

Closed TrafalgarZZZ closed 1 day ago

TrafalgarZZZ commented 1 day ago

Purpose of this PR

Proposed changes:

<Change 1>
<Change 2>
<Change 3>

Change Category

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[ ] Documentation update

Rationale

google-oss-prow[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/arena/blob/master/OWNERS)~~ [ChenYi015] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ChenYi015 commented 1 day ago

@TrafalgarZZZ Well done! Thanks for reporting and fixing the issue. /lgtm