search

kubeflow / arena

A CLI for Kubeflow.
Apache License 2.0
733 stars 177 forks source link

[chore] compatibility problem with tf-operator v1.0.1 #498

Open gaocegege opened 3 years ago

gaocegege commented 3 years ago

https://github.com/kubeflow/tf-operator/commit/984adc287e6fe82841e4ca282dc9a2cbb71e2d4a#diff-c3cd90fce520caf42f3e75efbc527abd0d119271103de3fe6f0168e8c5fb8c33L30

Kubeflow/common unifies the label for all jobs, while we are still using tf-replica-type in arena. Should we update to replica-type?

cc @cheyang

gaocegege commented 3 years ago

cc @happy2048

happy2048 commented 3 years ago

we have using https://github.com/AliyunContainerService/tf-operator/tree/v1.0-aliyun-branch to build tf-operator for arena, this branch includes some custom features different from kubeflow/tf-operator.

gaocegege commented 3 years ago

Can we merge the change https://github.com/AliyunContainerService/tf-operator/commit/61b59190c296c3cd6ad6ec12058d0eb27029c4de to the mainstream?

happy2048 commented 3 years ago

Can we merge the change AliyunContainerService/tf-operator@61b5919 to the mainstream?

ok, I will commit a PR.