Closed shannonbradshaw closed 2 years ago
@kimwnasptd and @jbottum please review.
/lgtm
Contents looks good to me. Waiting for @johnugeorge 's confirmation on the linked blog post /lgtm
/lgtm
@shannonbradshaw on line 126, we might want to add a line that reminds folks that KF components versions have their own versioning schemes. Now -> This chart provides links to important details from the Working Groups including their 1.4 tracking issues and change logs, along with their. roadmaps. We might add.... Please note that the Working Groups use version numbers that are specific to their project. As a result, many Kubeflow components, which have been incorporated and tested in Kubeflow 1.4, may have a different version number than 1.4.
@shannonbradshaw I am okay if others want to remove the tracking issues, but I would prefer to leave them in. If others want them out and you have the time, please remove. In the same chart (~line 160), the training operators Roadmap is listed as Kubeflow Roadmap...It should be Training Operator Roadmap. Also, KFServing should be 0.6.1, https://github.com/kserve/kserve/releases/tag/v0.6.1...this is on ~line 226
Thank you for doing this @shannonbradshaw @jbottum! /lgtm
@shannonbradshaw on line 126, we might want to add a line that reminds folks that KF components versions have their own versioning schemes. Now -> This chart provides links to important details from the Working Groups including their 1.4 tracking issues and change logs, along with their. roadmaps. We might add.... Please note that the Working Groups use version numbers that are specific to their project. As a result, many Kubeflow components, which have been incorporated and tested in Kubeflow 1.4, may have a different version number than 1.4.
@jbottum I addressed the above over the weekend but forgot to let you know.
@shannonbradshaw I am okay if others want to remove the tracking issues, but I would prefer to leave them in. If others want them out and you have the time, please remove. In the same chart (~line 160), the training operators Roadmap is listed as Kubeflow Roadmap...It should be Training Operator Roadmap. Also, KFServing should be 0.6.1, https://github.com/kserve/kserve/releases/tag/v0.6.1...this is on ~line 226
@jbottum I addressed all these comments and pushed the changes.
/lgtm
Can we get another lgtm after my edits? Then I'll approve
assuming we will edit or add the "presentation" link on line 261 to the 1.4 video (on youtube), then this looks good to me. For reference, the video content is here: https://drive.google.com/file/d/16MPvMI0HOo4FlYu73tTHu22k6AziNbxD/view
/lgtm
Want to wait until that is added? It's processing right now.
On Tue, Oct 12, 2021 at 11:05 AM Josh Bottum @.***> wrote:
assuming we will edit or add the "presentation" link on line 261 to the 1.4 video (on youtube), then this looks good to me. For reference, the video content is here: https://drive.google.com/file/d/16MPvMI0HOo4FlYu73tTHu22k6AziNbxD/view
/ltgm
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/kubeflow/blog/pull/109#issuecomment-941247715, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABREJVIOLMX5JUIT7HT2YHDUGR2HPANCNFSM5FUZWYJA .
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shannonbradshaw, terrytangyuan, theadactyl
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Initial commit of Kubeflow 1.4 blog post on behalf of @jbottum