search

kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
16 stars 35 forks source link

1.5 blog post #114

Closed shannonbradshaw closed 2 years ago

shannonbradshaw commented 2 years ago

fyi: @jbottum

jbottum commented 2 years ago

@johnugeorge @zijianjoy @kimwnasptd @andreyvelich @pvaneck @theadactyl Hi Johnu, James, Kimonas, Andrey, Paul - May I please ask for your help on the Kubeflow 1.5 blog post? I am requesting final edits and /lgtm. We would like to post on Tuesday (3/15) and @theadactyl need some time for final reviews. Thanks for your help!

zijianjoy commented 2 years ago

/lgtm for Kubeflow Pipelines

johnugeorge commented 2 years ago

I had added and reviewed changes in the release draft.

/lgtm from Training WG and AutoML WG

jbottum commented 2 years ago

@shannonbradshaw I made a few suggested edits. after those, I am /lgtm

jbottum commented 2 years ago

@theadactyl - We are getting close to a final version of this post. We have most of the /lgtm from the Working Groups. I have made my last suggestions (above) and I believe @shannonbradshaw is going to review and add his. We will then be ready for your final review and approval.

shannonbradshaw commented 2 years ago

/lgtm

@jbottum please submit any changes you have as suggestions. See step 6 here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request

google-oss-prow[bot] commented 2 years ago

@shannonbradshaw: you cannot LGTM your own PR.

In response to [this](https://github.com/kubeflow/blog/pull/114#issuecomment-1068039293): >/lgtm > >@jbottum please submit any changes you have as suggestions. See step 6 here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jbottum commented 2 years ago

/lgtm

jbottum commented 2 years ago

@theadactyl - would you please provide the final review and approval based on the /lgtms above. We would like to post this today. Thanks!

jbottum commented 2 years ago

@shannonbradshaw are you ok with these changes ? We should probably get this posted soon.

jbottum commented 2 years ago

/ltgm

jbottum commented 2 years ago

/approve

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbottum, shannonbradshaw To complete the pull request process, please assign kramachandran after the PR has been reviewed. You can assign the PR to them by writing /assign @kramachandran in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/blog/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jbottum commented 2 years ago

@zijianjoy Hey James - We would like to post this. Can you please help push this over the line ?

kimwnasptd commented 2 years ago

/lgtm

Thank you @jbottum @shannonbradshaw!

jbottum commented 2 years ago

@zijianjoy Hey James - this needs an approval, can you please /approve ?

jbottum commented 2 years ago

/approve

jbottum commented 2 years ago

@shannonbradshaw I have reverted. From the owners file, it appears that these are the approvers:

@james-jwu @kramachandran @theadactyl would you please approve this (/approve). FYI, our original due date for this was Tuesday, March 15 and would appreciate your effort to help get this posted.

jbottum commented 2 years ago

/assign @james-jwu

js-ts commented 2 years ago

/assign @zijianjoy

annajung commented 2 years ago

To help with the review, here is the link to the blog post preview

@jbottum @shannonbradshaw not a blocker comment, since we're still waiting on approval. What do you think about adding the link to the 1.5 release video as mentioned in @js-ts's comment?

jbottum commented 2 years ago

To help with the review, here is the link to the blog post preview

@jbottum @shannonbradshaw not a blocker comment, since we're still waiting on approval. What do you think about adding the link to the 1.5 release video as mentioned in @js-ts's comment?

@shannonbradshaw I think we could put this text after Tutorial 2 and right before the last section.

v1.5 Presentation Recording - The Community has also recorded a presentation on the new features in v1.5. This 30 minute recording includes valuable information and is presented by the Kubeflow Community’s v1.5 Release Team and Working Group leads.

jbottum commented 2 years ago

@shannonbradshaw @kimwnasptd should we include these proposed file changes and get approves on the final ?

jbottum commented 2 years ago

@shannonbradshaw trying to close this out. I reverted the prior merge here,, https://github.com/kubeflow/blog/pull/115

kimwnasptd commented 2 years ago

Great, lets redo the PR then.

@james-jwu @zijianjoy regarding the process, I see that a blog post was not merged after the initial PR was merged. Why was this the case? Is it because Josh manually merged his branch?

Also, how was this possible from an ACL point of view?

zijianjoy commented 2 years ago

Let's try to merge the new PR with explicit OWNER's lgtm/approval using comments this time. The post-submit was not triggered by the accidental merge.

kimwnasptd commented 2 years ago

ACK! I see that @jbottum reverted his PR. I'll submit a new one with the last proposed changes above and lets merge it with the established flow.