search

kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
16 stars 35 forks source link

post: KF 1.5.1 release blog post #119

Closed kimwnasptd closed 2 years ago

kimwnasptd commented 2 years ago

Making the PR for the KF 1.5.1 patch release from https://docs.google.com/document/d/1L9gaISYy73N84UKpkro1EQFvcB2LexoDIORIKZ2DQKE/edit

/cc @jbottum @annajung @surajkota @DomFleischmann @theadactyl @james-jwu @zijianjoy

kimwnasptd commented 2 years ago

You can also take a peek of the current preview in https://deploy-preview-119--infallible-murdock-d05108.netlify.app/, from the above github checks

jbottum commented 2 years ago

@surajkota Hey Suraj - Could you pleases review this PR and provide your comments and lgtm ?

jbottum commented 2 years ago

@annajung would you please review this PR ?

surajkota commented 2 years ago

/approve

jbottum commented 2 years ago

@kimwnasptd line 17 probably need a period at the end of the sentence (after "here"). With that change, I provide

/lgtm

annajung commented 2 years ago

/lgtm

kimwnasptd commented 2 years ago

I've added the proposed changes from the comments above. I believe it should be ready to merge.

cc @zijianjoy @jbottum

jbottum commented 2 years ago

@kimwnasptd I believe we need a "," after Mercedes Benz clusters, which I believe is on line 13. then its /lgtm

zijianjoy commented 2 years ago

/lgtm /approve

Thank you for composing the blog post!

jbottum commented 2 years ago

/lgtm

jbottum commented 2 years ago

@kimwnasptd can we please get this posted ?

zijianjoy commented 2 years ago

@droctothorpe Would you like to sign the CLA to pass presubmit check?

droctothorpe commented 2 years ago

Thanks, @zijianjoy. I've definitely signed the CLA. Investigating why it's not properly mapped to this commit now.

droctothorpe commented 2 years ago

Signed a new CLA with my mythicalsunlight@gmail.com gmail account. Not sure why this commit was flagged while others passed this gate without issue.

droctothorpe commented 2 years ago

CLA check confirmed passing now.

zijianjoy commented 2 years ago

/lgtm /approve

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kimwnasptd, shivaylamba, surajkota, yhwang, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/blog/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment