Closed DomFleischmann closed 1 year ago
@johnugeorge @andreyvelich @kimwnasptd @kubeflow/wg-pipeline-leads @akgraner Hi WG and Team Leads - would you please provide your lgtm on your particular sections before Monday ? Thank you!
Looks like Johnu's email hasn't signed CLA : joh******rge@nutanix.com. @johnugeorge Would you like to sign CLA?
Thanks @johnugeorge and @andreyvelich I added both suggestions and amended my initial commit to avoid the cla issue. @zijianjoy do you know what is causing the CI failures?
@DomFleischmann looks like the CI problem is related to https://github.com/jekyll/minima/pull/686
changing the social link under _config.yaml
seem to build without an error
- { platform: github, user_url: "https://github.com/kubeflow" }
- { platform: twitter, user_url: "https://twitter.com/kubeflow" }
or you can lock the version of the jekyll/minima used to the previous version before the breaking change as it currently points to the latest
@DomFleischmann looks like the CI problem is related to jekyll/minima#686
changing the social link under
_config.yaml
seem to build without an error- { platform: github, user_url: "https://github.com/kubeflow" } - { platform: twitter, user_url: "https://twitter.com/kubeflow" }
Thank you @annajung !! That seems to have fixed the issue.
@DomFleischmann looks like the CI problem is related to jekyll/minima#686 changing the social link under
_config.yaml
seem to build without an error- { platform: github, user_url: "https://github.com/kubeflow" } - { platform: twitter, user_url: "https://twitter.com/kubeflow" }
Thank you @annajung !! That seems to have fixed the issue.
@annajung realized that this workaround was not rendering the blog correctly so we decided to pin minima to a version before the breaking change. Now everything seems to be displayed correctly.
@theadactyl @james-jwu Please be aware that the 1.7 blog post is nearing completion and we would like to publish it tomorrow. Would you please review it ? Thank you.
/lgtm /approve
Thank you Dominik! It looks good to me at high level. If further changes are needed, let's create separate PR to fix them.
@DomFleischmann Due to the aforementioned changes proposed by the KFP team, we will need to re-write portions of the blog, including the Title and Intro. As this is significant, I have started that draft in the previous working doc. Once cleaned up, we can move it to this PR. https://docs.google.com/document/d/1ViBVM41W0FzsbOe1lGklwm8msG93A6lqtTz8In43kUE/edit
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: DomFleischmann, zijianjoy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
@chensun @zijianjoy @gkcalat we have updated the pipelines section and our introduction removing mentions of ParallelFor and transfomers. Let us know if this looks good to you now.
Add blog post for the 1.7 Release