search

kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
17 stars 40 forks source link

Clarification for reviewing/approval process #14

Closed terrytangyuan closed 3 years ago

terrytangyuan commented 4 years ago

Currently in README, we have the following:

A group of designated subject matter experts will review. A Google representative will provide the final approval.

We should probably clarify who these people are and how to request for their reviews/approvals. Perhaps define a OWNERS file would help?

hamelsmu commented 4 years ago

@jlewi how do we go about deciding this

jlewi commented 4 years ago

@terrytangyuan Yeah an OWNERs file is good way to ensure PRs are only approved by people trusted to enforce the review process.

As for subject matter owners; there's two things

  1. Person who submits PR/blog post should try to identify and ping appropriate subject matter experts.
  2. Blog managers should help sherherd the process and assign the PR to appropriate SME
terrytangyuan commented 3 years ago

The current OWNERS file has @karkumar as approval but this user has no activity for years on GitHub so the handle is probably incorrect.

jlewi commented 3 years ago

yup it should be @kramachandran https://github.com/kubeflow/community/tree/master/wg-pipelines https://github.com/kubeflow/internal-acls/blob/bf392a1a643b36ac0285ee03530db26946579fad/github-orgs/kubeflow/org.yaml#L165

@kramachandran switched the GitHub account he is using.