kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
16 stars 35 forks source link

Add KF 1.9 release blog post v1 #150

Closed StefanoFioravanzo closed 1 month ago

StefanoFioravanzo commented 2 months ago

original doc: https://docs.google.com/document/d/1Ykd1a7wioTMmWwhtjmIf6buxXeeK4__RWIPwE7Jyd3s/edit

Let's continue reviewing here.

cc @rimolive @jbottum @thesuperzapper @tarilabs @andreyvelich @juliusvonkohout @hbelmiro @rareddy @johnugeorge @terrytangyuan

tarilabs commented 2 months ago

btw, not sure if it's only my experience, but looking at the draft preview, all links are not displayed with underline/blue colour, only after clicking on them 🧐 🤔 it is very likely totally unrelated to this PR itself, but thought about mentioning it?

Screenshot 2024-07-09 at 07 32 33

StefanoFioravanzo commented 2 months ago

@tarilabs thanks! It's the first time I publish a blob here so I don't know what's causing this. I'll clean up a few things, turn this into an open PR and then we'll figure this out.

tarilabs commented 2 months ago

@tarilabs thanks! It's the first time I publish a blob here so I don't know what's causing this. I'll clean up a few things, turn this into an open PR and then we'll figure this out.

I later investigated further, appears to be an issue with the blog unrelated by this PR, worth imho to be followed-up separately my2c

jbottum commented 1 month ago

@StefanoFioravanzo I made a few suggestions, small changes. IMO, the getting started link does need to be fixed before approval. I have not checked all of the links from within the post...I think they help but there are a lot of them.

jbottum commented 1 month ago

sorry about the faulty closure. Let me know if my action caused any issues.

StefanoFioravanzo commented 1 month ago

@jbottum what do you mean by "fixing the getting started link?" It does point to our docs getting started page

EDIT - Ah you mean the 1.9 getting started. Yes that's our only blocker

jbottum commented 1 month ago

@StefanoFioravanzo @terrytangyuan @andreyvelich are we good to approve this ? It looks pretty close. I like putting in the names of the GSOC students. We could add it later. The post is long so we might find that we need some corrections after posting.

andreyvelich commented 1 month ago

@StefanoFioravanzo @terrytangyuan @andreyvelich are we good to approve this ? It looks pretty close. I like putting in the names of the GSOC students. We could add it later. The post is long so we might find that we need some corrections after posting.

I think, we should add the GSoC students to this blog post before publishing. It should be very simple change

rareddy commented 1 month ago

@andreyvelich you can add this link https://summerofcode.withgoogle.com/programs/2024/organizations/kubeflow

StefanoFioravanzo commented 1 month ago

Added GSoC students list and link

rimolive commented 1 month ago

@andreyvelich @jbottum @terrytangyuan I think all the review comments were addressed. Let us know if we can approve and finally announce the big news.

jbottum commented 1 month ago

/lgtm

andreyvelich commented 1 month ago

Thanks @StefanoFioravanzo /lgtm

jbottum commented 1 month ago

/approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbottum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/blog/blob/master/OWNERS)~~ [jbottum] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment