search

kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
16 stars 35 forks source link

chore: remove unnecessary primer.css conflicting with minima theme #151

Closed tarilabs closed 1 month ago

tarilabs commented 1 month ago

It seems to me use of primer.css (GitHub default's design system) conflicts with this blog's theme ("minima" customized) in some places, but most importantly unvisited links.

This result in being unable to distinguish in a blog post which are the available links (common in websites). Examples will be provided down below.

This PR proposes to remove primer.css imports to avoid said conflicts. This PR is continued from: https://github.com/kubeflow/blog/pull/150#issuecomment-2220198719

cc @StefanoFioravanzo @rimolive @juliusvonkohout wdyt?

Examples today Vs this_pr

Screenshot 2024-07-25 at 10 48 44 (2)

Screenshot 2024-07-25 at 10 48 22 (2)

as can be seen in Netlify preview in the action runs below.

juliusvonkohout commented 1 month ago

It looks better to me :-)

lampajr commented 1 month ago

fwiw it looks better to me too :rocket:

/lgtm

ederign commented 1 month ago

/lgtm

Thanks Matteo!

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/blog/blob/master/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment