search

kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
16 stars 38 forks source link

Blog Post: Data science meets devops. #31

Closed jlewi closed 4 years ago

jlewi commented 4 years ago
hamelsmu commented 4 years ago

@jlewi could be bigger even? Up to you

image

github-actions[bot] commented 4 years ago

A preview build of this branch has been generated for SHA: e20707d955731efc61efafcf7639a2b96d69f277 and can be viewed live at: https://5f28a1cbeba2c1acb07cbb80--infallible-murdock-d05108.netlify.app

The current fastpages site built from master can be viewed for comparison here

google-cla[bot] commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

hamelsmu commented 4 years ago

@jlewi one more thing, it might be worthwhile once this is merged to check how the image card is going to look on social media, we might have to experiment a bit and have a replicated version of the meme that is smaller so it doesn't get cropped by social media.

Its hard to preview this without checking in the images to the repo because this aspect is done with absolute links. I can help with this once you are ready

google-cla[bot] commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

jlewi commented 4 years ago

Thanks @hamelsmu ; PTAL. I uploaded a bigger image almost 2x (simply scaling the existing image didn't look so good).

I tried scaling the image to be the width of the text but it didn't look as good IMO; the image ended up being too large. You should be able to scale it via CSS if you want to take a look and compare. Let me know what you think.

hamelsmu commented 4 years ago

@jlewi ok looks reasonable to me 👍

hamelsmu commented 4 years ago

@jlewi ready to merge?

jlewi commented 4 years ago

/hold cancel

jlewi commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

@jlewi: you cannot LGTM your own PR.

In response to [this](https://github.com/kubeflow/blog/pull/31#issuecomment-668717080): >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described [here]()

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/blog/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment