Closed jbottum closed 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jbottum
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@hamelsmu now have pull request created but missing the images and need to improve some text and formatting.
@hamelsmu ok, this still needs some work...from others who are providing content, plus I think the format needs work, there are probably some typos. Do I just alert the others that the PR is open and they can make their edits ? or do I merge the pull request and then iterate after its merged ?
@hamelsmu Hi Hamel - I merged this PR and should not have. I think I should hide it and let people update it. How do I hide it...i.e. You can hide a blog post from the home page by setting the front matter hide to true.
Hi Josh may I suggest you get an engineer on your team to assist you with this process. I unfortunately do not have access to a computer for a while
On Wed, Nov 18, 2020 at 7:03 PM Josh Bottum notifications@github.com wrote:
@hamelsmu https://github.com/hamelsmu Hi Hamel - I merged this PR and should not have. I think I should hide it and let people update it. How do I hide it...i.e. You can hide a blog post from the home page by setting the front matter hide to true.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubeflow/blog/pull/58#issuecomment-730095849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALKJEWR2GA2U7LGV4WMBK3SQSDGTANCNFSM4T2XOL4A .
Initial content for blog post, still needs some editing, formatting and images. original content was from this google doc, https://docs.google.com/document/d/1fMAqZ9hv0p22TA6uMM2gpii65pMPiKJAKxSQ6e6RFho/edit?ts=5fb4991b