Closed andreyvelich closed 3 years ago
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: castrojo.
Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andreyvelich
To complete the pull request process, please assign theadactyl after the PR has been reviewed.
You can assign the PR to them by writing /assign @theadactyl
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@kramachandran @theadactyl Can you help with this Blog Post review, please ?
Hi! Thanks for tagging me. Can we get an LGTM from a subject matter expert aside from blog author? I think there are some copy edits needed here as well, which I'd love help with. Otherwise looks good to me -- happy to approve when those are taken care of.
Hi! Thanks for tagging me. Can we get an LGTM from a subject matter expert aside from blog author? I think there are some copy edits needed here as well, which I'd love help with. Otherwise looks good to me -- happy to approve when those are taken care of.
Thank you @theadactyl! Please let me know which parts can be modified in this Blog from your point of view.
I removed WIP status. /hold for the review.
Thank you so much for the review @theadactyl! I addressed your comments.
@andreyvelich very nice effort. I have 3 comments.
(this sentence might need some commas or broken in to two sentences) - Since Katib can execute various Kubernetes resources, users are able to run Experiments which can optimize not only ML models but also any software, code or program to make it more efficient with optimization algorithms provided by Katib.
(should "perform" be "provide a"?) We are continually working on the new Katib UI to perform better User Experience and native integration with Kubeflow central dashboard.
(this sentence probably needs to be broken into two or more sentences...and I struggle with best and worse in the same sentence) : Currently, Katib supports the Median Stopping Rule which stops a pending Trial X at step S if the Trial's best objective value by step S is worse than the median value of the running averages of all completed Trials' objectives reported up to step S. Suggestion.... Currently, Katib supports the Median Stopping Rule. The Medium Stopping rule stops if the Trial's best objective is lower than the median value of all Trials' objectives completed to that point.
Thank you for the comments @jbottum! What do you think ?
(this sentence might need some commas or broken in to two sentences) - Since Katib can execute various Kubernetes resources, users are able to run Experiments which can optimize not only ML models but also any software, code or program to make it more efficient with optimization algorithms provided by Katib.
Since Katib can execute various Kubernetes resources, users are able to run not only ML models optimization Experiments. They can also enhance any software, code or program to make it more efficient with optimization algorithms provided by Katib.
(should "perform" be "provide a"?) We are continually working on the new Katib UI to perform better User Experience and native integration with Kubeflow central dashboard.
Make sense, changed.
(this sentence probably needs to be broken into two or more sentences...and I struggle with best and worse in the same sentence) : Currently, Katib supports the Median Stopping Rule which stops a pending Trial X at step S if the Trial's best objective value by step S is worse than the median value of the running averages of all completed Trials' objectives reported up to step S. Suggestion.... Currently, Katib supports the Median Stopping Rule. The Medium Stopping rule stops if the Trial's best objective is lower than the median value of all Trials' objectives completed to that point.
Thanks! What do you think about this "Currently, Katib supports the Median Stopping Rule. The Medium Stopping rule stops a running Trial at the step S if the Trial's best objective value is lower than the median value of all succeeded Trials' objectives reported up to that step S."
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich, theadactyl
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LMK when all stakeholders are ready for merge.
/assign @gaocegege @johnugeorge @jbottum
/lgtm
@gaocegege @johnugeorge If you are fine with the changes, please can you give your lgtm
and we can move forward?
/lgtm
Thanks everyone for the help on this blog! /hold cancel
Congrats!
On Wed, Mar 10, 2021 at 2:38 AM Google OSS Prow Robot < notifications@github.com> wrote:
Merged #71 https://github.com/kubeflow/blog/pull/71 into master.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubeflow/blog/pull/71#event-4435280602, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABREJVM3EDF64ZRJCTKFGMTTC442DANCNFSM4YNYNQWA .
I added Blog Post: "Kubeflow Katib: Scalable, Portable and Cloud Native System for AutoML". Name is under discussion, if you have any other options please let me know.
/cc @jbottum @gaocegege @johnugeorge @castrojo @amsaha