Closed zw0610 closed 3 years ago
/hold pending rendering test
@kubeflow/wg-training-leads
@andreyvelich
/lgtm
/hold cancel
rendering issue fixed
/lgtm /assign @terrytangyuan @xieydd
Nit - I would consider removing "like precedent cloud native adoptions" in final paragraph.
Nit - I would consider removing "like precedent cloud native adoptions" in final paragraph.
sounds reasonable. While there are some precedents like that, it's not always the case.
Please take a look, thanks for your time :smile:
@andreyvelich
cc @tgaddair
Awesome stuff, @gaocegege! Great to see Elastic Horovod in Kubeflow :)
ping @theadactyl
@gaocegege thanks for the ping! Just confirming that the primary content is re: fully OSS tech. Is that correct?
Yeah, the feature is merged into kubeflow/mpi-operator.
Great, thanks @gaocegege! /approved for my part Do we need lgtm from Josh for copy?
/lgtm
@zw0610 Nice job! Although some of the sentence structure and word flow might be a little unusual, I believe the message is conveyed. Also, since I do not have the technical depth to validate the examples, I will rely on the Kubeflow Training WG approvals, which have been provided above. Thank you for this post!
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan, theadactyl, zw0610
The full list of commands accepted by this bot can be found here.
The pull request process is described here
https://github.com/kubeflow/community/issues/500
@kubeflow/wg-training-leads