Closed deepk2u closed 3 years ago
@deepk2u Thanks for this detailed review of the challenges in 1.2. I think this post is well written and provides a good foundation. As you may have seen, the installation patterns have been simplified in Kubeflow 1.3, and several of the issues have been addressed i.e istio upgrades. I would expect that most users will be migrating to 1.3 because of the new ML workflows and new installation / operating process (especially with manifests and kustomize and without kfctl). Question - Is there a way to incorporate which of these issues will still exist after 1.3 ?
@jbottum I am thinking to write another continuation blog for upgrades/challenges with 1.3, which will answer a lot of the questions around that. I haven't started on 1.3 install yet, hoping to do it in the coming weeks. Will that work?
@deepk2u Although I think your proposal can work, I am a little concerned about the timing. We will be promoting KF 1.3 in the next few weeks. We are trying to attract new (and previous) users. I like your article, it has great value, but some (alternative) projects / vendors might exploit. Many KF contributors have spent late nights on 1.3 ...and I promised them a great launch (so I am too close). I differ to you. Maybe we should discuss live?
@jbottum Okay, I will try to incorporate the changes for 1.3, but it might delay the post significantly if I hit any issues with 1.3 RCs.
@jbottum @Bobgy I have updated to content to reflect changes after 1.3 release. Could you please take a look and do the needful?
/lgtm @deepk2u thanks for your patience and great work to document Intuit's experience. I really like your thorough and detailed analysis. I did not have SMEs inspect the technical details, so I am assuming that your details are accurate and/or you will modify if corrections are needed. I would like to point out that Kubeflow has been developed by volunteer contributors and respectfully ask you to consider softening some wording i.e. Fixing the authn/authz, After doing all these changes, authentication was still not working.
@jbottum Thanks for the feedback, we are actively using Kubeflow at Intuit now and we would like to improve and contribute as much as possible in all aspects so that it is useful for everyone else as well.
I have tried to incorporate your feedback and changed the wording. The blog content is also verified by the Istio Mesh team at Intuit, but if we still need any changes later, I will be more than happy to incorporate those changes.
pinging @theadactyl for approval
@deepk2u thanks for this blog post! I've committed some copy edits. Take a look and make sure everything checks out on your end -- I'd be happy to merge once you're good to go.
@jbottum thanks for the review!
@theadactyl thanks for the edits, it looks good to me. Please go ahead and merge.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepk2u, theadactyl
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@deepk2u Hey deepak, fyi... in the istio section, there are some comments and you have typo...Similar to Pipeliens module you can bring other modules as well
/assign @theadactyl