search

kubeflow / blog

Kubeflow blog based on fastpages
https://blog.kubeflow.org
Apache License 2.0
16 stars 38 forks source link

Fixes typos in kubeflow install blog #93

Closed deepk2u closed 3 years ago

deepk2u commented 3 years ago

@jbottum I have tried to fix all the typos and used Grammarly to fix some of the grammar as well, let me know if you still see any other issues.

Thanks for pointing it out though.

jbottum commented 3 years ago

/lgtm

deepk2u commented 3 years ago

/assign @kramachandran

deepk2u commented 3 years ago

Pinging @kramachandran for approval.

deepk2u commented 3 years ago

Pinging @kramachandran @james-jwu for approval

james-jwu commented 3 years ago

/lgtm /approve

deepk2u commented 3 years ago

@james-jwu you need to mention approved you missed ed in your comment.

james-jwu commented 3 years ago

/approved

deepk2u commented 3 years ago

@james-jwu usually it gets auto merged after the approval, not sure what’s wrong

@theadactyl approved last one like this: https://github.com/kubeflow/blog/pull/91#issuecomment-845394070

does it need new line? not sure!

deepk2u commented 3 years ago

/assign @james-jwu

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepk2u, james-jwu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/blog/blob/master/OWNERS)~~ [james-jwu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
james-jwu commented 3 years ago

I manually applied the LGTM and Approved labels.