kubeflow / code-intelligence

ML-Powered Developer Tools, using Kubeflow
https://medium.com/kubeflow/reducing-maintainer-toil-on-kubeflow-with-github-actions-and-machine-learning-f8568374daa1?source=friends_link&sk=ac77444f00c230e7d787edbfb0081918
MIT License
55 stars 21 forks source link

[label bot] code duplication among notebooks #122

Open jlewi opened 4 years ago

jlewi commented 4 years ago

I'm noticing a lot of code duplication between the various notebooks. Which makes it hard to identify which notebook to use. This is probably tech debt as a result of us creating new copies of code rather than refactoring and reusing. We should try to clean this up.

  1. Code shared between notebooks should be moved into reusable functions, classes, or modules in the py directory
  2. notebooks should call the reusable functions
  3. notebooks should clearly explain what they are doing so its obvious how different notebooks compare.

As an example the following two notebooks both seem to be fetching GitHub issues and computing embeddings

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.57

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.