search

kubeflow / code-intelligence

ML-Powered Developer Tools, using Kubeflow
https://medium.com/kubeflow/reducing-maintainer-toil-on-kubeflow-with-github-actions-and-machine-learning-f8568374daa1?source=friends_link&sk=ac77444f00c230e7d787edbfb0081918
MIT License
55 stars 21 forks source link

[Model Sync Controller] Remove post processing of the kubebuilder CRD #172

Open jlewi opened 4 years ago

jlewi commented 4 years ago

We currently post-process the CRD generated by kubebuilder here https://github.com/kubeflow/code-intelligence/blob/7f514162b674b3bcd28bc4600c7b2f22a7703c39/Label_Microservice/go/Makefile#L55

This post-processing removes validation for PipelineRunRef and just treats it as an arbitrary json.

This is undesirable because we'd like validation to insure PipelineRunRef's are correct.

This was necessary because PipelineParams implement custom marshling and kubebuilder didn't handle this correctly at the time.

This should be fixed by https://github.com/kubernetes-sigs/controller-tools/pull/427 which should be in controller-gen 0.3.0 and later.

I think I'm currently using v0.2.5. We should try to upgrade and see if that fixes the issue and get rid of our postprocessing.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.63

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.