kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

[feature] Suppory unit test by providing handlers for updateStatus and DeleteJob #106

Open gaocegege opened 3 years ago

gaocegege commented 3 years ago
    // TODO(ChanYiLin): these are originally for testing, but with using common library,
    // we can not replcae the function. Also need to update or remove some tests

    // tc.updateStatusHandler = tc.UpdateJobStatusInApiServer
    // set delete handler.
    // tc.deleteTFJobHandler = tc.DeleteJob

It will be better to have such handlers to replace them when running test cases.

/cc @ChanYiLin

ChanYiLin commented 3 years ago

Thanks for the reminder, I'll take this issue.

ChanYiLin commented 3 years ago

/assign @ChanYiLin