reorder job cleanup and completion time setting

shaowei-su commented 3 years ago

Follow to tf-operator issue: https://github.com/kubeflow/tf-operator/issues/1223 Reorder the jobStatus.CompletionTime before job cleanup, where completion time is used for TTL check.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

shaowei-su commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

shaowei-su commented 3 years ago

@googlebot I fixed it.

shaowei-su commented 3 years ago

@terrytangyuan thanks for the stamp! it seems that master branch CI build is failing:

./hack/../pkg is out of date. Please run hack/update-codegen.sh
The command "./hack/verify-codegen.sh" exited with 1.

any suggestions on how to fix this?

terrytangyuan commented 3 years ago

Could you run hack/update-codegen.sh to see if there's any update in codegen that needs to be updated?

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaowei-su, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

shaowei-su commented 3 years ago

Hi @terrytangyuan is it possible to cut a new release for common, so that downstream issue can be resolved: https://github.com/kubeflow/tf-operator/issues/1223

kubeflow / common