Closed Thor-wl closed 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Thor-wl
To complete the pull request process, please assign richardsliu after the PR has been reviewed.
You can assign the PR to them by writing /assign @richardsliu
in a comment when ready.
The full list of commands accepted by this bot can be found here.
# volcano.sh/apis/pkg/apis/scheduling
../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:38:3: cannot use &PodGroup literal (type *PodGroup) as type runtime.Object in argument to scheme.AddKnownTypes:
*PodGroup does not implement runtime.Object (missing DeepCopyObject method)
../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:39:3: cannot use &PodGroupList literal (type *PodGroupList) as type runtime.Object in argument to scheme.AddKnownTypes:
*PodGroupList does not implement runtime.Object (missing DeepCopyObject method)
../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:40:3: cannot use &Queue literal (type *Queue) as type runtime.Object in argument to scheme.AddKnownTypes:
*Queue does not implement runtime.Object (missing DeepCopyObject method)
../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:41:3: cannot use &QueueList literal (type *QueueList) as type runtime.Object in argument to scheme.AddKnownTypes:
*QueueList does not implement runtime.Object (missing DeepCopyObject method)
# volcano.sh/apis/pkg/apis/bus/v1alpha1
../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:46:3: cannot use &Command literal (type *Command) as type runtime.Object in argument to scheme.AddKnownTypes:
*Command does not implement runtime.Object (missing DeepCopyObject method)
../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:47:3: cannot use &CommandList literal (type *CommandList) as type runtime.Object in argument to scheme.AddKnownTypes:
*CommandList does not implement runtime.Object (missing DeepCopyObject method)
go build failed. Can you help fix it?
# volcano.sh/apis/pkg/apis/scheduling ../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:38:3: cannot use &PodGroup literal (type *PodGroup) as type runtime.Object in argument to scheme.AddKnownTypes: *PodGroup does not implement runtime.Object (missing DeepCopyObject method) ../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:39:3: cannot use &PodGroupList literal (type *PodGroupList) as type runtime.Object in argument to scheme.AddKnownTypes: *PodGroupList does not implement runtime.Object (missing DeepCopyObject method) ../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:40:3: cannot use &Queue literal (type *Queue) as type runtime.Object in argument to scheme.AddKnownTypes: *Queue does not implement runtime.Object (missing DeepCopyObject method) ../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:41:3: cannot use &QueueList literal (type *QueueList) as type runtime.Object in argument to scheme.AddKnownTypes: *QueueList does not implement runtime.Object (missing DeepCopyObject method) # volcano.sh/apis/pkg/apis/bus/v1alpha1 ../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:46:3: cannot use &Command literal (type *Command) as type runtime.Object in argument to scheme.AddKnownTypes: *Command does not implement runtime.Object (missing DeepCopyObject method) ../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:47:3: cannot use &CommandList literal (type *CommandList) as type runtime.Object in argument to scheme.AddKnownTypes: *CommandList does not implement runtime.Object (missing DeepCopyObject method)
go build failed. Can you help fix it?
Yes, i'm fixing it. I'll submit another commit for it.
/assign @shinytang6
@gaocegege: GitHub didn't allow me to assign the following users: shinytang6.
Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
@gaocegege @Jeffwan Can you help for rerun the CI ? The root reason is some bugs in the volcano.sh/apis and i've fixed it.
It seems that the CI machine didn't go get
the latest code of volcano.sh/apis v1.16.15 and still used cache. Becase the CI failed log shows that my error line is 39, and it doesn't match the latest code. I'll try to submit a new PR and trigger the CI again.
It seems that the CI machine didn't
go get
the latest code of volcano.sh/apis v1.16.15 and still used cache. Becase the CI failed log shows that my error line is 39, and it doesn't match the latest code. I'll try to submit a new PR and trigger the CI again.
maybe you need to run go mod tidy
again?
It seems that the CI machine didn't
go get
the latest code of volcano.sh/apis v1.16.15 and still used cache. Becase the CI failed log shows that my error line is 39, and it doesn't match the latest code. I'll try to submit a new PR and trigger the CI again.maybe you need to run
go mod tidy
again?
Let me have a try,
Signed-off-by: Thor-wl 13164644535@163.com