search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

update volcano crd api to v1.16 #121

Closed Thor-wl closed 3 years ago

Thor-wl commented 3 years ago

Signed-off-by: Thor-wl 13164644535@163.com

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Thor-wl To complete the pull request process, please assign richardsliu after the PR has been reviewed. You can assign the PR to them by writing /assign @richardsliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Jeffwan commented 3 years ago 
# volcano.sh/apis/pkg/apis/scheduling

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:38:3: cannot use &PodGroup literal (type *PodGroup) as type runtime.Object in argument to scheme.AddKnownTypes:

    *PodGroup does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:39:3: cannot use &PodGroupList literal (type *PodGroupList) as type runtime.Object in argument to scheme.AddKnownTypes:

    *PodGroupList does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:40:3: cannot use &Queue literal (type *Queue) as type runtime.Object in argument to scheme.AddKnownTypes:

    *Queue does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:41:3: cannot use &QueueList literal (type *QueueList) as type runtime.Object in argument to scheme.AddKnownTypes:

    *QueueList does not implement runtime.Object (missing DeepCopyObject method)

# volcano.sh/apis/pkg/apis/bus/v1alpha1

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:46:3: cannot use &Command literal (type *Command) as type runtime.Object in argument to scheme.AddKnownTypes:

    *Command does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:47:3: cannot use &CommandList literal (type *CommandList) as type runtime.Object in argument to scheme.AddKnownTypes:

    *CommandList does not implement runtime.Object (missing DeepCopyObject method)

go build failed. Can you help fix it?

Thor-wl commented 3 years ago 
# volcano.sh/apis/pkg/apis/scheduling

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:38:3: cannot use &PodGroup literal (type *PodGroup) as type runtime.Object in argument to scheme.AddKnownTypes:

  *PodGroup does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:39:3: cannot use &PodGroupList literal (type *PodGroupList) as type runtime.Object in argument to scheme.AddKnownTypes:

  *PodGroupList does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:40:3: cannot use &Queue literal (type *Queue) as type runtime.Object in argument to scheme.AddKnownTypes:

  *Queue does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/scheduling/register.go:41:3: cannot use &QueueList literal (type *QueueList) as type runtime.Object in argument to scheme.AddKnownTypes:

  *QueueList does not implement runtime.Object (missing DeepCopyObject method)

# volcano.sh/apis/pkg/apis/bus/v1alpha1

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:46:3: cannot use &Command literal (type *Command) as type runtime.Object in argument to scheme.AddKnownTypes:

  *Command does not implement runtime.Object (missing DeepCopyObject method)

../../../../pkg/mod/volcano.sh/apis@v1.16.15/pkg/apis/bus/v1alpha1/register.go:47:3: cannot use &CommandList literal (type *CommandList) as type runtime.Object in argument to scheme.AddKnownTypes:

  *CommandList does not implement runtime.Object (missing DeepCopyObject method)

go build failed. Can you help fix it?

Yes, i'm fixing it. I'll submit another commit for it.

gaocegege commented 3 years ago

/assign @shinytang6

google-oss-robot commented 3 years ago

@gaocegege: GitHub didn't allow me to assign the following users: shinytang6.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubeflow/common/pull/121#issuecomment-809012074): >/assign @shinytang6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Thor-wl commented 3 years ago

@gaocegege @Jeffwan Can you help for rerun the CI ? The root reason is some bugs in the volcano.sh/apis and i've fixed it.

Thor-wl commented 3 years ago

It seems that the CI machine didn't go get the latest code of volcano.sh/apis v1.16.15 and still used cache. Becase the CI failed log shows that my error line is 39, and it doesn't match the latest code. I'll try to submit a new PR and trigger the CI again.

shinytang6 commented 3 years ago

It seems that the CI machine didn't go get the latest code of volcano.sh/apis v1.16.15 and still used cache. Becase the CI failed log shows that my error line is 39, and it doesn't match the latest code. I'll try to submit a new PR and trigger the CI again.

maybe you need to run go mod tidy again?

Thor-wl commented 3 years ago

It seems that the CI machine didn't go get the latest code of volcano.sh/apis v1.16.15 and still used cache. Becase the CI failed log shows that my error line is 39, and it doesn't match the latest code. I'll try to submit a new PR and trigger the CI again.

maybe you need to run go mod tidy again?

Let me have a try,