search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Clean up go modules #127

Closed Jeffwan closed 3 years ago

Jeffwan commented 3 years ago

This is a follow up PR of #123 to clean up go modules after we switch to volcano-api. Removing kubernetes unrelated dependencies help reduce size the repo, especially for users who use go mod vendor or go mod download

Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, shinytang6, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [Jeffwan,terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
merlintang commented 3 years ago

/lgtm

On Wed, Mar 31, 2021 at 10:25 AM shinytang6 @.***> wrote:

@.**** commented on this pull request.

In go.mod https://github.com/kubeflow/common/pull/127#discussion_r604550458:

@@ -14,33 +14,13 @@ require ( k8s.io/apimachinery v0.16.15 k8s.io/client-go v0.16.15 k8s.io/code-generator v0.18.3

k8s.io/code-generator can also be downgraded to v1.16.15 by the way though it has no effect here :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubeflow/common/pull/127#pullrequestreview-624842374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK5R6JMLD6X2CZV3HUKCO3TGKB3NANCNFSM42C736KA .

gaocegege commented 3 years ago

The command "./hack/verify-codegen.sh" exited with 1.

Jeffwan commented 3 years ago

The command "./hack/verify-codegen.sh" exited with 1.

fixed.