Closed Jeffwan closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Jeffwan, shinytang6, terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
On Wed, Mar 31, 2021 at 10:25 AM shinytang6 @.***> wrote:
@.**** commented on this pull request.
In go.mod https://github.com/kubeflow/common/pull/127#discussion_r604550458:
@@ -14,33 +14,13 @@ require ( k8s.io/apimachinery v0.16.15 k8s.io/client-go v0.16.15 k8s.io/code-generator v0.18.3
k8s.io/code-generator can also be downgraded to v1.16.15 by the way though it has no effect here :)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubeflow/common/pull/127#pullrequestreview-624842374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK5R6JMLD6X2CZV3HUKCO3TGKB3NANCNFSM42C736KA .
The command "./hack/verify-codegen.sh" exited with 1.
The command "./hack/verify-codegen.sh" exited with 1.
fixed.
This is a follow up PR of #123 to clean up go modules after we switch to volcano-api. Removing kubernetes unrelated dependencies help reduce size the repo, especially for users who use
go mod vendor
orgo mod download
Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com