search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

project cannot complie with kubeflow/common v0.3.3 and client-go v0.19 #132

Closed chxk closed 3 years ago

chxk commented 3 years ago

I use operator-sdk(v1.5.0) and this repo to scaffold a project. go.mod

require (
    github.com/go-logr/logr v0.3.0
    github.com/kubeflow/common v0.3.3
    github.com/onsi/ginkgo v1.14.1
    github.com/onsi/gomega v1.10.2
    k8s.io/api v0.19.2
    k8s.io/apimachinery v0.19.2
    k8s.io/client-go v0.19.2
    sigs.k8s.io/controller-runtime v0.7.2
)

By I met errors when I try to compile, 

/Users/xxxx/test-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
# volcano.sh/apis/pkg/client/clientset/versioned/typed/bus/v1alpha1
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:72:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("commands").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:89:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("commands").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:106:8: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("commands").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Watch
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:116:5: not enough arguments in call to c.client.Post().Namespace(c.ns).Resource("commands").Body(command).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:129:5: not enough arguments in call to c.client.Put().Namespace(c.ns).Resource("commands").Name(command.ObjectMeta.Name).Body(command).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:141:5: not enough arguments in call to c.client.Delete().Namespace(c.ns).Resource("commands").Name(name).Body(options).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:157:5: not enough arguments in call to c.client.Delete().Namespace(c.ns).Resource("commands").VersionedParams(&listOptions, scheme.ParameterCodec).Timeout(timeout).Body(options).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/bus/v1alpha1/command.go:170:5: not enough arguments in call to c.client.Patch(pt).Namespace(c.ns).Resource("commands").SubResource(subresources...).Name(name).Body(data).Do
        have ()
        want (context.Context)
# volcano.sh/apis/pkg/client/clientset/versioned/typed/batch/v1alpha1
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:73:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("jobs").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:90:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("jobs").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:107:8: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("jobs").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Watch
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:117:5: not enough arguments in call to c.client.Post().Namespace(c.ns).Resource("jobs").Body(job).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:130:5: not enough arguments in call to c.client.Put().Namespace(c.ns).Resource("jobs").Name(job.ObjectMeta.Name).Body(job).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:146:5: not enough arguments in call to c.client.Put().Namespace(c.ns).Resource("jobs").Name(job.ObjectMeta.Name).SubResource("status").Body(job).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:158:5: not enough arguments in call to c.client.Delete().Namespace(c.ns).Resource("jobs").Name(name).Body(options).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:174:5: not enough arguments in call to c.client.Delete().Namespace(c.ns).Resource("jobs").VersionedParams(&listOptions, scheme.ParameterCodec).Timeout(timeout).Body(options).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/batch/v1alpha1/job.go:187:5: not enough arguments in call to c.client.Patch(pt).Namespace(c.ns).Resource("jobs").SubResource(subresources...).Name(name).Body(data).Do
        have ()
        want (context.Context)
# volcano.sh/apis/pkg/client/clientset/versioned/typed/scheduling/v1beta1
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:73:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("podgroups").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:90:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("podgroups").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:107:8: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("podgroups").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Watch
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:117:5: not enough arguments in call to c.client.Post().Namespace(c.ns).Resource("podgroups").Body(podGroup).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:130:5: not enough arguments in call to c.client.Put().Namespace(c.ns).Resource("podgroups").Name(podGroup.ObjectMeta.Name).Body(podGroup).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:146:5: not enough arguments in call to c.client.Put().Namespace(c.ns).Resource("podgroups").Name(podGroup.ObjectMeta.Name).SubResource("status").Body(podGroup).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:158:5: not enough arguments in call to c.client.Delete().Namespace(c.ns).Resource("podgroups").Name(name).Body(options).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:174:5: not enough arguments in call to c.client.Delete().Namespace(c.ns).Resource("podgroups").VersionedParams(&listOptions, scheme.ParameterCodec).Timeout(timeout).Body(options).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/podgroup.go:187:5: not enough arguments in call to c.client.Patch(pt).Namespace(c.ns).Resource("podgroups").SubResource(subresources...).Name(name).Body(data).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/queue.go:70:5: not enough arguments in call to c.client.Get().Resource("queues").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
        have ()
        want (context.Context)
../../../go/pkg/mod/volcano.sh/apis@v1.2.0-k8s1.16.15/pkg/client/clientset/versioned/typed/scheduling/v1beta1/queue.go:70:5: too many errors
# github.com/kubeflow/common/pkg/controller.v1/control
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/pod_control.go:113:55: not enough arguments in call to r.KubeClient.CoreV1().Pods(namespace).Patch
        have (string, types.PatchType, []byte)
        want (context.Context, string, types.PatchType, []byte, "k8s.io/apimachinery/pkg/apis/meta/v1".PatchOptions, ...string)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/pod_control.go:149:64: not enough arguments in call to r.KubeClient.CoreV1().Pods(namespace).Create
        have (*"k8s.io/api/core/v1".Pod)
        want (context.Context, *"k8s.io/api/core/v1".Pod, "k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/pod_control.go:170:55: not enough arguments in call to r.KubeClient.CoreV1().Pods(namespace).Get
        have (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
        want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/pod_control.go:182:56: not enough arguments in call to r.KubeClient.CoreV1().Pods(namespace).Delete
        have (string, nil)
        want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".DeleteOptions)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/service_control.go:68:59: not enough arguments in call to r.KubeClient.CoreV1().Services(namespace).Patch
        have (string, types.PatchType, []byte)
        want (context.Context, string, types.PatchType, []byte, "k8s.io/apimachinery/pkg/apis/meta/v1".PatchOptions, ...string)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/service_control.go:93:69: not enough arguments in call to r.KubeClient.CoreV1().Services(namespace).Create
        have (*"k8s.io/api/core/v1".Service)
        want (context.Context, *"k8s.io/api/core/v1".Service, "k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/service_control.go:116:63: not enough arguments in call to r.KubeClient.CoreV1().Services(namespace).Get
        have (string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
        want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/controller.v1/control/service_control.go:128:60: not enough arguments in call to r.KubeClient.CoreV1().Services(namespace).Delete
        have (string, nil)
        want (context.Context, string, "k8s.io/apimachinery/pkg/apis/meta/v1".DeleteOptions)
# github.com/kubeflow/common/pkg/util/k8sutil
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/util/k8sutil/client.go:77:19: not enough arguments in call to r.DoRaw
        have ()
        want (context.Context)
../../../go/pkg/mod/github.com/kubeflow/common@v0.3.3/pkg/util/k8sutil/client.go:91:19: not enough arguments in call to r.DoRaw
        have ()
        want (context.Context)

How can I solve this problem?

Jeffwan commented 3 years ago

@chxk

https://github.com/kubeflow/common/pull/126

Let me merge this PR and unblock you

chxk commented 3 years ago

@Jeffwan Thanks, and what is the estimated time of merging?

@chxk

126

Let me merge this PR and unblock you