search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Type of replicaType is not consistent in common project #134

Closed MartinForReal closed 3 years ago

MartinForReal commented 3 years ago

Is there any thought about why type of replicaType is not consistent across the common project?

e.g.

https://github.com/kubeflow/common/blob/eb55ddefdea6d4034af9f4fe66dd202ff3af400e/pkg/apis/common/v1/interface.go#L47

vs

https://github.com/kubeflow/common/blob/eb55ddefdea6d4034af9f4fe66dd202ff3af400e/pkg/apis/common/v1/interface.go#L57

I think maybe it is a good idea to define replicaType as commonv1.ReplicaType.

Jeffwan commented 3 years ago

It makes no difference from usage perspective but I agree we should make it consistent.