search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

change type of rtype to commonv1.ReplicaType #135

Closed MartinForReal closed 3 years ago

MartinForReal commented 3 years ago

related: #134

MartinForReal commented 3 years ago

/assign @terrytangyuan

carmark commented 3 years ago

Did you do gofmt?

MartinForReal commented 3 years ago

Did you do gofmt?

Please refer to https://travis-ci.com/github/kubeflow/common/builds/226788990

Jeffwan commented 3 years ago

https://github.com/kubeflow/common/blob/eb55ddefdea6d4034af9f4fe66dd202ff3af400e/pkg/apis/common/v1/types.go#L151

Nice catch. ReplicaType is string and we may forget to make them consistent. This will be a user facing change and operators will need to make corresponding change after upgrade.

/lgtm

Jeffwan commented 3 years ago

/approve

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment