Closed MartinForReal closed 3 years ago
/assign @jeffwan
@terrytangyuan Yeah I think so.
this kind of validation utility is still under discussion. ref: https://github.com/golang/go/issues/27005 A possible workaround is as described here: https://blog.urth.org/2019/08/13/testing-go-mod-tidiness-in-ci/
#!/bin/bash
set -e
go mod tidy
STATUS=$( git status --porcelain go.mod go.sum )
if [ ! -z "$STATUS" ]; then
echo "Running go mod tidy modified go.mod and/or go.sum"
exit 1
fi
exit 0
Would you like to add it to part of the CI as well in this PR?
/lgtm /assign @terrytangyuan
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Can you please update go mod?
Or is it caused by the go version?
Can you please update go mod?
Or is it caused by the go version?
tricky part is: I can't reproduce the error on my laptop. So I just manually copy missing configuration from build logs and it works.
@terrytangyuan @gaocegege Since I've resolved build error, please take a look. Thanks!
/lgtm
Remove unnecessary replace statements Add test dependencies.