search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

optimize the ttl of job #137

Closed HeGaoYuan closed 3 years ago

HeGaoYuan commented 3 years ago

my implementation refer to https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/ttlafterfinished/ttlafterfinished_controller.go#L290

gaocegege commented 3 years ago

Thanks for your contribution! :tada: :+1:

johnugeorge commented 3 years ago

/lgtm

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
HeGaoYuan commented 3 years ago

@terrytangyuan @gaocegege But I left a todo: Is the jobStatus.CompletionTime maybe nil ?