google-oss-robot
commented
3 years ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
In GenGeneralName, we should use lower case.
In the past we do the conversion outside the function since the replicaType is a string. Now its type is replicaType, thus we should do it in the function.
/cc @terrytangyuan @MartinForReal
Signed-off-by: cegao cegao@tencent.com