search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Add fully-qualified labels #150

Closed alculquicondor closed 3 years ago

alculquicondor commented 3 years ago

Add a label for operator name. Mark non-fully-qualified labels as Deprecated.

Fixes #148

Pending tasks to be done in future releases #149

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alculquicondor commented 3 years ago

Can we have a new release of this repo?

Jeffwan commented 3 years ago

Can we have a new release of this repo?

@alculquicondor Here's the diff. https://github.com/kubeflow/common/compare/v0.3.6...master I think we can cut one release or wait for more features. Can also use commit in go.mod?

alculquicondor commented 3 years ago

I would prefer we have a release than using a commit in go.mod

gaocegege commented 3 years ago

@Jeffwan WDYT, should we have a release after the all-in-one operator is merged?

Jeffwan commented 3 years ago

@gaocegege @alculquicondor I think it's ok to cut a release. We probably need to define release strategy for this repo.

I assume changes like #150 are breaking changes? If job controller is released, on going jobs will be affected.

Do we want to cut 0.3.7 or cut release branch 0.4.0? We didn't cut release branches for this version yet. I think it's time to follow semantic versioning?

alculquicondor commented 3 years ago

It's only breaking for the controllers that don't use the common controller. For the ones that do, the new controller still respects the deprecated labels. But 0.4.0 makes the most sense

Jeffwan commented 3 years ago

Sounds good. Let's cut release-0.4 branch and cut 0.4.0 tag for the new release. sounds good to you? @gaocegege