search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

fix replicaType key for filtering pods and services #151

Closed zw0610 closed 3 years ago

zw0610 commented 3 years ago

In #150, when updating the selector labels for matching services and pods, key ReplicaIndexLabel is introduced while I believe it needs ReplicaTypeLabel.

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jeffwan after the PR has been reviewed. You can assign the PR to them by writing /assign @jeffwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alculquicondor commented 3 years ago

/lgtm

Although I added a version with a unit test #152