search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Cut release-0.4 branch and cut 0.4.0 tag #153

Closed alculquicondor closed 3 years ago

alculquicondor commented 3 years ago

Sounds good. Let's cut release-0.4 branch and cut 0.4.0 tag for the new release. sounds good to you? @gaocegege

Originally posted by @Jeffwan in https://github.com/kubeflow/common/issues/150#issuecomment-898603418

alculquicondor commented 3 years ago

/assign @Jeffwan

alculquicondor commented 3 years ago

Perhaps it's worth also cutting a release-0.3 branch that doesn't contain #150

Jeffwan commented 3 years ago

@alculquicondor I double check the commit and seems this is not a breaking change. Do you think 0.3.x is better?

Sorry for the confusion. I didn't carefully review the change. if you are ok about 0.3.x, let's cut release-0.3 branch and 0.3.x tag then. I can help cut the tag today or tomorrow

alculquicondor commented 3 years ago

It is partially breaking. The controllers continue working. But if there was someone using the variables from the package directly, trying to query a cluster running old controllers, their filters might not work.

We might need a 0.5 branch when we fully remove the deprecated annotations later in the future.

Jeffwan commented 3 years ago

Please check it

https://github.com/kubeflow/common/releases/tag/v0.4.0

alculquicondor commented 3 years ago

It seems to be working kubeflow/mpi-operator#409

Jeffwan commented 3 years ago

Great! This can be closed.

/close

google-oss-robot commented 3 years ago

@Jeffwan: Closing this issue.

In response to [this](https://github.com/kubeflow/common/issues/153#issuecomment-906641722): >Great! This can be closed. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.