Closed Jeffwan closed 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from jeffwan after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
kubeflow/common master needs this change as well. Since file structure has been changed a little bit. Let's check in the codes later
I didn't notice Ce already filed https://github.com/kubeflow/tf-operator/pull/1384. I will close this one.
@gaocegege is there a way we can make this consistent between 1.2-branch and master? Seem 1.2 uses lister and master has to use Interface
Let me create a new informer from clientset and we can stick to lister here.
Can you please open an issue t keep track of it?
Fix this issue in v0.3 branch
https://github.com/kubeflow/tf-operator/issues/1382
The major problem is we didn't initial
PriorityClassLister
after common migration. When it tries to create podGroup and calculate resources, it's panic.I've tested with tf-operator master. v1.2.0 should be fixed same way
/cc @kubeflow/wg-training-leads