Use Interface instead of lister/informer in controller

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.

Apache License 2.0

51 stars 73 forks source link

Use Interface instead of lister/informer in controller #157

Open Jeffwan opened 3 years ago

Jeffwan commented 3 years ago

A follow up PR of https://github.com/kubeflow/common/pull/155

In the common code base, we still use low level listers and hasSynced which is not used in training-operator any more. Let's change to XXInterface from kubeClientSet. Otherwise, we have to create sharedInformers and then create listers which is unnecessary in latest client pattern

zw0610 commented 3 years ago

Good idea. May I assign this feature to myself?

Jeffwan commented 3 years ago

/assign @zw0610

Jeffwan commented 3 years ago

@zw0610 sure. Feel free to pick it up