search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Master fails to build #160

Closed Jeffwan closed 3 years ago

Jeffwan commented 3 years ago 
➜  common git:(master) ✗ go build ./...
go: github.com/kubeflow/common/pkg/reconciler.v1/common: package github.com/go-logr/logr imported from implicitly required module; to add missing requirements, run:
        go get github.com/go-logr/logr@v0.2.0
go: github.com/kubeflow/common/test_job/reconciler.v1/test_job: package github.com/go-logr/logr imported from implicitly required module; to add missing requirements, run:
        go get github.com/go-logr/logr@v0.2.0

dependency is missing in go.mod and it's imported implicitly.

/cc @zw0610

Jeffwan commented 3 years ago

After go get github.com/go-logr/logr@v0.2.0, I get other errors. 

➜  common git:(master) ✗ go build ./...
pkg/reconciler.v1/common/interface.go:27:2: no required module provides package sigs.k8s.io/controller-runtime; to add it:
        go get sigs.k8s.io/controller-runtime
pkg/reconciler.v1/common/gang.go:18:2: no required module provides package sigs.k8s.io/controller-runtime/pkg/client; to add it:
        go get sigs.k8s.io/controller-runtime/pkg/client
pkg/reconciler.v1/common/gang_volcano.go:32:2: no required module provides package sigs.k8s.io/controller-runtime/pkg/controller/controllerutil; to add it:
        go get sigs.k8s.io/controller-runtime/pkg/controller/controllerutil
pkg/reconciler.v1/common/reconciler.go:24:2: no required module provides package sigs.k8s.io/controller-runtime/pkg/log; to add it:
        go get sigs.k8s.io/controller-runtime/pkg/log
pkg/reconciler.v1/common/reconciler.go:25:2: no required module provides package sigs.k8s.io/controller-runtime/pkg/manager; to add it:
        go get sigs.k8s.io/controller-runtime/pkg/manager
Jeffwan commented 3 years ago

After adding sigs.k8s.io/controller-runtime v0.7.2, it shows some reconciler errors

# github.com/kubeflow/common/pkg/reconciler.v1/common
pkg/reconciler.v1/common/reconciler.go:60:24: cannot use jobInter (type *KubeflowJobReconciler) as type JobInterface in assignment:
        *KubeflowJobReconciler does not implement JobInterface (missing ExtractJobStatus method)
pkg/reconciler.v1/common/reconciler.go:66:24: cannot use jobInter (type *KubeflowJobReconciler) as type JobInterface in assignment:
        *KubeflowJobReconciler does not implement JobInterface (missing ExtractJobStatus method)
pkg/reconciler.v1/common/reconciler.go:73:34: cannot use jobInter (type *KubeflowJobReconciler) as type JobInterface in assignment:
        *KubeflowJobReconciler does not implement JobInterface (missing ExtractJobStatus method)
gaocegege commented 3 years ago

Do we have CI to test if it can be built successfully?

Jeffwan commented 3 years ago

@gaocegege As you know, CI was removed somehow. #161 Address this issue and we can close it. Github Action has been added