Closed Jeffwan closed 2 years ago
em.. Seems travis has been removed? see screenshot there. #141 introduces some build failures and I think that's the reason we didn't catch it in presubmit phase..
/cc @terrytangyuan @gaocegege anyone know who manages this?
I have no idea about it. Should we use github actions?
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gaocegege
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@gaocegege Not sure what happened to travis. Agree, I create an issue to track it https://github.com/kubeflow/common/issues/162
Address #161 #159
This is related to @zw0610 's reconciler v1 work.
I am trying to see if the CI can pass and why we didn't detect the failure earlier.