fix: add missing dependencies and missing methods

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.

Apache License 2.0

51 stars 73 forks source link

fix: add missing dependencies and missing methods #161

Closed Jeffwan closed 2 years ago

Jeffwan commented 2 years ago

Address #161 #159

This is related to @zw0610 's reconciler v1 work.

I am trying to see if the CI can pass and why we didn't detect the failure earlier.

Jeffwan commented 2 years ago

em.. Seems travis has been removed? see screenshot there. #141 introduces some build failures and I think that's the reason we didn't catch it in presubmit phase..

/cc @terrytangyuan @gaocegege anyone know who manages this?

gaocegege commented 2 years ago

I have no idea about it. Should we use github actions?

/lgtm /approve

google-oss-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Jeffwan commented 2 years ago

@gaocegege Not sure what happened to travis. Agree, I create an issue to track it https://github.com/kubeflow/common/issues/162