kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Enable GitHub action to build and test code #162

Closed Jeffwan closed 1 year ago

Jeffwan commented 2 years ago

See https://github.com/kubeflow/common/pull/161

141 introduces some build failures but we don't notice that before we merge the code. Travis somehow was deleted at that time. @gaocegege suggests to use Github actions.

Let's migrate scripts https://github.com/kubeflow/common/blob/master/.travis.yml to a Github Action manner.

We do need this to guarantee code quality

/help /good-first-issue

google-oss-robot commented 2 years ago

@Jeffwan: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/common/issues/162): >See https://github.com/kubeflow/common/pull/161 > >#141 introduces some build failures but we don't notice that before we merge the code. Travis somehow was deleted at that time. @gaocegege suggests to use Github actions. > >Let's migrate scripts https://github.com/kubeflow/common/blob/master/.travis.yml to a Github Action manner. > >/help >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Jeffwan commented 2 years ago

/assign @SumLare

google-oss-robot commented 2 years ago

@Jeffwan: GitHub didn't allow me to assign the following users: SumLare.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubeflow/common/issues/162#issuecomment-922522987): >/assign @SumLare Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Jeffwan commented 2 years ago

https://github.com/kubeflow/common/runs/3648012266 Interesting, in the latest workflow, I didn't see failure logs..

SumLare commented 2 years ago

Well https://status.coveralls.io/ still doesn't look good

Jeffwan commented 2 years ago

Yeah, that's the problem

bad response status from coveralls: 503
<h2>This website is under heavy load (queue full)</h2><p>We're sorry, too many people are accessing this website at the same time. We're working on this problem. Please try again later.</p>
gaocegege commented 2 years ago

coveralls crashes sometimes.

Jeffwan commented 2 years ago

Let's do this to overcome the issue. Since goveralls is nice to have, we can ignore the failures in CI. I can not believe recovery takes that long..

goveralls || echo "push to coveralls failed"

Jeffwan commented 2 years ago

This can be closed. thanks @SumLare !