Closed Jeffwan closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from jeffwan after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
could we move this pr forward? Apart from #166 , I believe we will have some elastic-related feature merging into common repository soon.
@Jeffwan I believe we can close this pr as #173 is merged.
Closed. Feel free to re-open if necessary.
I filed this PR https://github.com/kubeflow/common/pull/158 against release-0.3 branch but didn't check in code against master at that time. Please check details in #158 for the reason why I decide to revert this change.
I will file a PR in training-operator repo to use this branch. It will build operator using this branch. https://github.com/kubeflow/tf-operator/pull/1408
this change will unblock https://github.com/kubeflow/tf-operator/pull/1398
/cc @zw0610 @terrytangyuan @gaocegege