WIP: Revert #135: change rtype to commonv1.ReplicaType

[Jeffwan]

I filed this PR https://github.com/kubeflow/common/pull/158 against release-0.3 branch but didn't check in code against master at that time. Please check details in #158 for the reason why I decide to revert this change.

A few things to note

1. Since CI was removed for unknown reason. I manually verify the code quality

➜  common git:(revert_135_new) ✗ go build ./...
➜  common git:(revert_135_new) ✗ go test ./...
?       github.com/kubeflow/common/pkg/apis/common/v1   [no test files]
ok      github.com/kubeflow/common/pkg/controller.v1/common 0.018s
ok      github.com/kubeflow/common/pkg/controller.v1/control    0.028s
ok      github.com/kubeflow/common/pkg/controller.v1/expectation    0.015s
?       github.com/kubeflow/common/pkg/core [no test files]
ok      github.com/kubeflow/common/pkg/reconciler.v1/common 0.029s
ok      github.com/kubeflow/common/pkg/util 0.018s
?       github.com/kubeflow/common/pkg/util/k8sutil [no test files]
ok      github.com/kubeflow/common/pkg/util/labels  0.021s
?       github.com/kubeflow/common/pkg/util/signals [no test files]
ok      github.com/kubeflow/common/pkg/util/train   0.014s
?       github.com/kubeflow/common/test_job/apis/test_job/v1    [no test files]
?       github.com/kubeflow/common/test_job/client/clientset/versioned  [no test files]
?       github.com/kubeflow/common/test_job/client/clientset/versioned/fake [no test files]
?       github.com/kubeflow/common/test_job/client/clientset/versioned/scheme   [no test files]
?       github.com/kubeflow/common/test_job/client/clientset/versioned/typed/test_job/v1    [no test files]
?       github.com/kubeflow/common/test_job/client/clientset/versioned/typed/test_job/v1/fake   [no test files]
?       github.com/kubeflow/common/test_job/client/informers/externalversions   [no test files]
?       github.com/kubeflow/common/test_job/client/informers/externalversions/internalinterfaces    [no test files]
?       github.com/kubeflow/common/test_job/client/informers/externalversions/test_job  [no test files]
?       github.com/kubeflow/common/test_job/client/informers/externalversions/test_job/v1   [no test files]
?       github.com/kubeflow/common/test_job/client/listers/test_job/v1  [no test files]
?       github.com/kubeflow/common/test_job/controller.v1/test_job  [no test files]
?       github.com/kubeflow/common/test_job/reconciler.v1/test_job  [no test files]
?       github.com/kubeflow/common/test_job/test_util/v1    [no test files]

2. I will file a PR in training-operator repo to use this branch. It will build operator using this branch. https://github.com/kubeflow/tf-operator/pull/1408

3. this change will unblock https://github.com/kubeflow/tf-operator/pull/1398

/cc @zw0610 @terrytangyuan @gaocegege

[google-oss-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from jeffwan after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[zw0610]

could we move this pr forward? Apart from #166 , I believe we will have some elastic-related feature merging into common repository soon.

[zw0610]

@Jeffwan I believe we can close this pr as #173 is merged.

[terrytangyuan]

Closed. Feel free to re-open if necessary.