Closed zw0610 closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jeffwan after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeffwan
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/cc @kubeflow/wg-training-leads
Sorry for the delay. Let me merge #163 first before accepting any new changes. This is really annoying.
@Jeffwan could we move this pr forward as the revert string issue is resolved now.
@zw0610 sorry for late response. Please have a check on above comments
/lgtm /hold
This change looks good to me. Let's see if anyone else have further feedbacks. /cc @kubeflow/wg-training-leads
Any feedback before we can merge this pr? @kubeflow/wg-training-leads
/hold cancel
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Jeffwan, terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
To support
GenericJob
in tf-operator, a kind of Job independent from any deep learning frameworks, this pull request introduces the following modification toreconciler.v1
package:Kubeflow
)PodList
,ServiceList
converting issueGetReconcilerName
returned valuereconciler.v1
package by moving theKubeflowReconciler
to tf-operator https://github.com/kubeflow/tf-operator/pull/1398TestReconciler
construction function