search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

simplify reconciler #166

Closed zw0610 closed 2 years ago

zw0610 commented 2 years ago

To support GenericJob in tf-operator, a kind of Job independent from any deep learning frameworks, this pull request introduces the following modification to reconciler.v1 package:

  1. Simplify multiple reconciler names (by dropping redundant words like Kubeflow)
  2. Fix PodList, ServiceList converting issue
  3. Fix default GetReconcilerName returned value
  4. Simplify reconciler.v1 package by moving the KubeflowReconciler to tf-operator https://github.com/kubeflow/tf-operator/pull/1398
  5. Simplify TestReconciler construction function
google-oss-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jeffwan after the PR has been reviewed. You can assign the PR to them by writing /assign @jeffwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
terrytangyuan commented 2 years ago

/cc @kubeflow/wg-training-leads

Jeffwan commented 2 years ago

Sorry for the delay. Let me merge #163 first before accepting any new changes. This is really annoying.

zw0610 commented 2 years ago

@Jeffwan could we move this pr forward as the revert string issue is resolved now.

Jeffwan commented 2 years ago

@zw0610 sorry for late response. Please have a check on above comments

Jeffwan commented 2 years ago

/lgtm /hold

This change looks good to me. Let's see if anyone else have further feedbacks. /cc @kubeflow/wg-training-leads

zw0610 commented 2 years ago

Any feedback before we can merge this pr? @kubeflow/wg-training-leads

terrytangyuan commented 2 years ago

/hold cancel

terrytangyuan commented 2 years ago

/lgtm /approve

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [Jeffwan,terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment