search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Enforce backOffLimit in ExitCode restartPolicy #168

Closed goyalankit closed 2 years ago

goyalankit commented 2 years ago

The runPolicy.backOffLimit allows one to specify the sum total of number of times pods are allowed to restart before giving up. This change allows the backOffLimit to be applied when the restartPolicy is set to ExitCode

closes #167

goyalankit commented 2 years ago

/assign @jeffwan

Jeffwan commented 2 years ago

This is straightforward. The changes look good to me. /cc @gaocegege for confirmation.

@goyalankit Once this is merged. can you cherry-pick the change to release-0.3 branch as well?

goyalankit commented 2 years ago

Hi @gaocegege, please review when you get a chance.

google-oss-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [Jeffwan,gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment