search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

add MinReplicas and MaxReplicas field #171

Open qiankunli opened 2 years ago

qiankunli commented 2 years ago

Signed-off-by: bert.li qiankun.li@qq.com

in order to support pytorch elastic on kubernetes, design doc https://github.com/gaocegege/community-1/blob/elastic/proposals/pytorch-elastic-proposal.md

google-oss-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jeffwan after the PR has been reviewed. You can assign the PR to them by writing /assign @jeffwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zw0610 commented 2 years ago

Maybe we can further move elastic related parameters into RunPolicy field.

Jeffwan commented 2 years ago

Let's wait for https://github.com/kubeflow/community/pull/522 finalized and then come back to implementation. @qiankunli If you can add more use case, that would be great