search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Revert ReplicaType to string #173

Closed zw0610 closed 2 years ago

zw0610 commented 2 years ago

Since PR #163 has been stalled for a while, this pr tries to accomplish the same goal: revert rtype from commonv1.ReplicaType to string.

For any parameters, if it is of type commonv1.ReplicaType, it's reverted to string in this pr. However, parameters of type map[commonv1.ReplicaType]{any_value_type} remain unchanged.

@Jeffwan

zw0610 commented 2 years ago

@Jeffwan As tested in this pr https://github.com/kubeflow/training-operator/pull/1462, the updated common library works with training-operator.

Jeffwan commented 2 years ago

This PR can move forward once the issue here https://github.com/kubeflow/training-operator/pull/1462 is addressed.

zw0610 commented 2 years ago

ping @Jeffwan @terrytangyuan as the all tested passed: https://github.com/kubeflow/training-operator/pull/1462

However, please note that tf-controller is actually modified to keep up with the labels in new kubeflow/common. I submitted another pr https://github.com/kubeflow/training-operator/pull/1474 to fix the label issue.

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment