Closed zw0610 closed 2 years ago
@Jeffwan As tested in this pr https://github.com/kubeflow/training-operator/pull/1462, the updated common library works with training-operator.
This PR can move forward once the issue here https://github.com/kubeflow/training-operator/pull/1462 is addressed.
ping @Jeffwan @terrytangyuan as the all tested passed: https://github.com/kubeflow/training-operator/pull/1462
However, please note that tf-controller is actually modified to keep up with the labels in new kubeflow/common. I submitted another pr https://github.com/kubeflow/training-operator/pull/1474 to fix the label issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Since PR #163 has been stalled for a while, this pr tries to accomplish the same goal: revert rtype from
commonv1.ReplicaType
tostring
.For any parameters, if it is of type
commonv1.ReplicaType
, it's reverted tostring
in this pr. However, parameters of typemap[commonv1.ReplicaType]{any_value_type}
remain unchanged.@Jeffwan