Rollback #172 as it introduce hard requirements for the list values to not be empty

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.

Apache License 2.0

51 stars 73 forks source link

Rollback #172 as it introduce hard requirements for the list values to not be empty #174

Closed pugangxa closed 2 years ago

pugangxa commented 2 years ago

Due to #175, rollback the changes of listtype.

zw0610 commented 2 years ago

Would you mind check if this pr can fix issue #175 ?

pugangxa commented 2 years ago

Would you mind check if this pr can fix issue #175 ?

Oops, will take a look.

pugangxa commented 2 years ago

Rollback this change due to #175. Tried and it works now. @zw0610 @gaocegege

terrytangyuan commented 2 years ago

/lgtm /approve

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment