search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

feat: Add LabelSelector #177

Closed gaocegege closed 2 years ago

gaocegege commented 2 years ago

Ref https://github.com/kubeflow/training-operator/pull/1453 Ref https://github.com/kubeflow/community/pull/522

The LabelSelector will be used to support scale subresource in PyTorchJob and so on.

The field is new-added thus does not break the compatibility

Signed-off-by: Ce Gao ce.gao@outlook.com

gaocegege commented 2 years ago

/assign @Jeffwan @zw0610

zw0610 commented 2 years ago

LGTM This pr is critical for us to support elastic training for all kinds of training jobs in kubeflow training operator.

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment