search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

refactor PodGroup control with more generic design #185

Closed zw0610 closed 1 year ago

zw0610 commented 2 years ago

To support scheduler-plugins/coscheduling, this pr refactors the podgroup-related code.

Addressing: https://github.com/kubeflow/training-operator/issues/1518

Test PR: https://github.com/kubeflow/training-operator/pull/1526

zw0610 commented 2 years ago

test pr with kubeflow training-operator for this common pr: https://github.com/kubeflow/training-operator/pull/1526

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval by writing /assign @gaocegege in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

I take over this PR.

tenzen-y commented 1 year ago

@zw0610 We can close this PR since #203 is merged.

zw0610 commented 1 year ago

/close

On Sat, Jan 21, 2023 at 23:02 Yuki Iwai @.***> wrote:

@zw0610 https://github.com/zw0610 We can close this PR since #203 https://github.com/kubeflow/common/pull/203 is merged.

— Reply to this email directly, view it on GitHub https://github.com/kubeflow/common/pull/185#issuecomment-1399267265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7V6IW7FWRX7JWUCUOTPDDWTP3ATANCNFSM5M3H4B3A . You are receiving this because you were mentioned.Message ID: @.***>

google-oss-prow[bot] commented 1 year ago

@zw0610: Closed this PR.

In response to [this](https://github.com/kubeflow/common/pull/185#issuecomment-1399268063): >/close > >On Sat, Jan 21, 2023 at 23:02 Yuki Iwai ***@***.***> wrote: > >> @zw0610 We can close this PR since #203 >> is merged. >> >> — >> Reply to this email directly, view it on GitHub >> , or >> unsubscribe >> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.