search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Fix exitCode check #190

Closed georgkaleido closed 2 years ago

georgkaleido commented 2 years ago

The exitCode check works differently then described in the API

In addition the document exitCodes for Docker will not appear in a Kubernetes pod status (anymore?)

gaocegege commented 2 years ago

https://github.com/kubeflow/common/blob/master/pkg/apis/common/v1/types.go#L163-L168 The link is 404

georgkaleido commented 2 years ago

https://github.com/kubeflow/common/blob/master/pkg/apis/common/v1/types.go#L163-L168 The link is 404

Yeah sorry there was a markdown formatting error. Fixed now

johnugeorge commented 2 years ago

Can you rebase this PR as well?

johnugeorge commented 2 years ago

Can you rebase this PR as well?

georgkaleido commented 2 years ago

@johnugeorge done

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment