Closed yoanisgil closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign terrytangyuan after the PR has been reviewed.
You can assign the PR to them by writing /assign @terrytangyuan
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Can you add a test case?
I see a related PR for exit code - https://github.com/kubeflow/common/pull/190
/cc @gaocegege @terrytangyuan
No need to merge this one as https://github.com/kubeflow/common/pull/189 was already merged.
If a pod is in phase failure we have to create a new one. Currently it was assumed the pod would restart due to a RestartPolicy on the pod level. This doesn't work if the pod fails for a system reason.