Closed johnugeorge closed 1 year ago
/lgtm
Thanks for the fix!
/cc @terrytangyuan /cc @zw0610
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
As per docs, https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#scale-subresource
labelSelectorPath
referred byScale.Status.Selector
needs to be a stringThe field pointed by this JSON path must be a string field (not a complex selector struct) which contains a serialized label selector in string form.
Currently, HPA creation fails because of this reason. Related (https://github.com/kubeflow/training-operator/issues/1645, https://github.com/kubeflow/training-operator/issues/1626)
This change needs changes in training-operator as well which will be fixed in a different PR.
/assign @gaocegege /cc @kubeflow/wg-training-leads