search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Changing label selector type for HPA #197

Closed johnugeorge closed 1 year ago

johnugeorge commented 1 year ago

As per docs, https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#scale-subresource

labelSelectorPath referred by Scale.Status.Selector needs to be a string

The field pointed by this JSON path must be a string field (not a complex selector struct) which contains a serialized label selector in string form.

Currently, HPA creation fails because of this reason. Related (https://github.com/kubeflow/training-operator/issues/1645, https://github.com/kubeflow/training-operator/issues/1626)

This change needs changes in training-operator as well which will be fixed in a different PR.

/assign @gaocegege /cc @kubeflow/wg-training-leads

gaocegege commented 1 year ago

/lgtm

Thanks for the fix!

johnugeorge commented 1 year ago

/cc @terrytangyuan /cc @zw0610

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment