search

kubeflow / common

Common APIs and libraries shared by other Kubeflow operator repositories.
Apache License 2.0
51 stars 73 forks source link

Remove deprecated labels #200

Closed johnugeorge closed 1 year ago

johnugeorge commented 1 year ago

Remove deprecated labels from pods and services

Fixes: https://github.com/kubeflow/common/issues/149

Changes in Training operator will be created once this is merged

johnugeorge commented 1 year ago

/assign @alculquicondor

/cc @kubeflow/wg-training-leads

/hold Hold till review is completed

alculquicondor commented 1 year ago

/lgtm

Just make sure this change is restricted to a minor version upgrade (at least) and that it's properly documented.

johnugeorge commented 1 year ago

Yes. We will create a new release after this merge so that operators can use this. We will add a note in KF release that deprecated labels are removed in the release.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/common/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
johnugeorge commented 1 year ago

Thanks

/hold cancel